Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: requirements detection for alpine #204660

Merged
merged 1 commit into from
Feb 7, 2024
Merged

fix: requirements detection for alpine #204660

merged 1 commit into from
Feb 7, 2024

Conversation

deepak1556
Copy link
Collaborator

Fixes microsoft/vscode-remote-release#9499
Fixes #204611

  • /etc/os-release maybe not be available on certain distros
  • scope bitness check only on arm architecture
  • use dynamic loader in alpine scenario to identify musl version for cases where ldd can point to glibc sysroot
  • Reorder path checks in other cases to use ldconfig cache first before fallbacks

@deepak1556 deepak1556 added this to the February 2024 milestone Feb 7, 2024
@deepak1556 deepak1556 self-assigned this Feb 7, 2024
@deepak1556 deepak1556 enabled auto-merge (squash) February 7, 2024 22:56
@deepak1556 deepak1556 merged commit fdbf304 into main Feb 7, 2024
7 checks passed
@deepak1556 deepak1556 deleted the robo/improve_requirements_check branch February 7, 2024 23:19
@kbirger
Copy link

kbirger commented Feb 7, 2024

Thanks!

@DouweM DouweM mentioned this pull request Feb 12, 2024
Closed
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@connor4312 connor4312 connor4312 approved these changes

Assignees

@deepak1556 deepak1556

Labels
None yet
Projects
None yet
Milestone
February 2024
3 participants
@deepak1556 @kbirger @connor4312