fix: use legacy server as default with additional warnings #204377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isidorn
reviewed
Feb 5, 2024
isidorn
previously approved these changes
Feb 5, 2024
|
As @deepak1556 pointed out there are layering issues So it looks like the changes we did in common/remote.contribution.ts should be in @bpasero @alexdima @aeschli can you help with the layering warnings? Suggestions? We could just ignore for the recovery release. |
|
I think the warning can be ignored if you are certain that the But I also think the contribution could be moved over to the |
|
Moved it to browser layer, thanks @bpasero |
deepak1556
commented
Feb 5, 2024
src/vs/workbench/contrib/remote/browser/remoteConnectionHealth.ts
Outdated
Show resolved
Hide resolved
deepak1556
force-pushed
the
robo/revert_server_glibc_requirements
branch
from
44cc6b1 to
4b53bfa
Compare
alexdima
reviewed
Feb 6, 2024
deepak1556
force-pushed
the
robo/revert_server_glibc_requirements
branch
from
4b53bfa to
7bcd639
Compare
isidorn
approved these changes
Feb 6, 2024
KidiIT
reviewed
Feb 6, 2024
There was a problem hiding this comment.
Reviewed and tested all the items and found no signs of any damage to the unit or anything else that may have occurred during the installation of the system or the unit itself and all other components of the system that were installed in the unit as needed for the job or any damage to the home or any other activity in the unit.🫶❤️
deepak1556
added a commit
that referenced
this pull request
Feb 6, 2024
* ci: switch to glibc 2.17 remote server * chore: signal user about unsupported connection * chore: address review comments * chore: update nodejs build * chore: bump distro * chore: lower the minimum requirements * fix: glibc version check * chore: remove explicit connection disposal
deepak1556
added a commit
that referenced
this pull request
Feb 6, 2024
…204482) * fix: use legacy server as default with additional warnings (#204377) * ci: switch to glibc 2.17 remote server * chore: signal user about unsupported connection * chore: address review comments * chore: update nodejs build * chore: bump distro * chore: lower the minimum requirements * fix: glibc version check * chore: remove explicit connection disposal * chore: update distro
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #204344
Depends on https://github.com/microsoft/vscode-node/pull/56