Backport node-gyp fix from main #195225
Merged
Backport node-gyp fix from main #195225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Try with node 18.17 * And change product compile * Use 18.15, same as the local version
* Test using nvmrc in CI * Force run yarn * fix * Bump nvmrc to latest * Revert "Force run yarn" This reverts commit af741f3. * Make all jobs use node from nvmrc And install node-gyp where needed
chrmarti
approved these changes
Oct 10, 2023
joaomoreno
added
the
candidate
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picks: c9740ad 8ee50f2 7d4027b