Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nvmrc in CI #194836

Merged
merged 6 commits into from
Oct 5, 2023
Merged

Use nvmrc in CI #194836

merged 6 commits into from
Oct 5, 2023

Conversation

roblourens
Copy link
Member

No description provided.

This reverts commit af741f3.
And install node-gyp where needed
@roblourens roblourens marked this pull request as ready for review October 5, 2023 01:05
@roblourens roblourens enabled auto-merge (squash) October 5, 2023 01:05
@vscodenpa vscodenpa added this to the October 2023 milestone Oct 5, 2023
@roblourens roblourens merged commit 7d4027b into main Oct 5, 2023
@roblourens roblourens deleted the roblou/basic-prawn branch October 5, 2023 02:08
@roblourens roblourens changed the title Test using nvmrc in CI Use nvmrc in CI Oct 5, 2023
@joaomoreno
Copy link
Member

Cool!

joaomoreno pushed a commit that referenced this pull request Oct 10, 2023
* Test using nvmrc in CI

* Force run yarn

* fix

* Bump nvmrc to latest

* Revert "Force run yarn"

This reverts commit af741f3.

* Make all jobs use node from nvmrc
And install node-gyp where needed
joaomoreno added a commit that referenced this pull request Oct 10, 2023
* Try with node 18.17 (#194663)

* Try with node 18.17

* And change product compile

* Use 18.15, same as the local version

* Fix the rest of the node version references (#194677)

* Test using nvmrc in CI (#194836)

* Test using nvmrc in CI

* Force run yarn

* fix

* Bump nvmrc to latest

* Revert "Force run yarn"

This reverts commit af741f3.

* Make all jobs use node from nvmrc
And install node-gyp where needed

---------

Co-authored-by: Rob Lourens <roblourens@gmail.com>
bpasero pushed a commit that referenced this pull request Oct 13, 2023
* Test using nvmrc in CI

* Force run yarn

* fix

* Bump nvmrc to latest

* Revert "Force run yarn"

This reverts commit af741f3.

* Make all jobs use node from nvmrc
And install node-gyp where needed
bpasero pushed a commit that referenced this pull request Oct 13, 2023
* Test using nvmrc in CI

* Force run yarn

* fix

* Bump nvmrc to latest

* Revert "Force run yarn"

This reverts commit af741f3.

* Make all jobs use node from nvmrc
And install node-gyp where needed
bpasero pushed a commit that referenced this pull request Oct 13, 2023
* Test using nvmrc in CI

* Force run yarn

* fix

* Bump nvmrc to latest

* Revert "Force run yarn"

This reverts commit af741f3.

* Make all jobs use node from nvmrc
And install node-gyp where needed
bpasero pushed a commit that referenced this pull request Oct 14, 2023
* Test using nvmrc in CI

* Force run yarn

* fix

* Bump nvmrc to latest

* Revert "Force run yarn"

This reverts commit af741f3.

* Make all jobs use node from nvmrc
And install node-gyp where needed
bpasero pushed a commit that referenced this pull request Oct 14, 2023
* Test using nvmrc in CI

* Force run yarn

* fix

* Bump nvmrc to latest

* Revert "Force run yarn"

This reverts commit af741f3.

* Make all jobs use node from nvmrc
And install node-gyp where needed
Alex0007 pushed a commit to Alex0007/vscode that referenced this pull request Oct 26, 2023
* Test using nvmrc in CI

* Force run yarn

* fix

* Bump nvmrc to latest

* Revert "Force run yarn"

This reverts commit af741f3.

* Make all jobs use node from nvmrc
And install node-gyp where needed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants