Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Error Message if TypeScript Settings Update Fails #18130

Merged

Conversation

mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Jan 4, 2017

Fixes #18127

Show error messages if the TS workspace or user settings update fails. Currently we always show success messages even if the update fails.

Fixes microsoft#18127

Show error messages if the workspace or user settings update fails
@mjbvz mjbvz requested a review from dbaeumer January 4, 2017 23:34
@mjbvz mjbvz merged commit 9eb91d2 into microsoft:master Jan 5, 2017
@dbaeumer
Copy link
Member

dbaeumer commented Jan 9, 2017

+1.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript Shows "tsdk Updated" Message Even if the Settings Update Fails
3 participants