Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Navigate locations in current file" commands #171193

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maxrothman
Copy link

@maxrothman maxrothman commented Jan 12, 2023

Resolves #166314

These changes are a proof-of-concept and are not complete, but my hope is that putting them up can start a discussion about how they might get reviewed and potentially accepted.

Current limitations:

  • "current editor" and "default" history stacks are completely separate, which leads to some slightly sketchy behavior. If you have changes A, B and C in the current editor, and then run "go back in edit locations" twice your cursor will be at A. If you then run "go back in edit locations in current editor", your cursor will be at B.
  • I have made no attempt to update the existing context keys scheme. I think there's a discussion to be had about which context keys might make sense.
  • In the linked issue, I discussed unifying all the navigation commands into a single command that takes scope and filter arguments. I have made no attempt to make that change, since that's somewhat orthogonal to the underlying history service functionality. If that change is desired, I'm happy to add it to this or another pull request.
  • I haven't added or updated any tests. I figured let's decide what the changes are first, then I can write tests that verify the behavior.

@maxrothman
Copy link
Author

@microsoft-github-policy-service agree

@sbatten sbatten assigned bpasero and unassigned sbatten Jan 12, 2023
@bpasero bpasero added this to the Backlog milestone Jan 12, 2023
@bpasero bpasero marked this pull request as draft December 10, 2024 05:12
@bpasero
Copy link
Member

bpasero commented Dec 18, 2024

Unless there are strong objections, I feel to close this PR as the original issue did not get enough asks for it.

@bpasero bpasero added the info-needed Issue requires more information from poster label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Navigate locations in current file" commands
4 participants