Adding tab navigation to language select hint #139581
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a new file is create a hint asks the user to specify the desired programming language. This commit introduces a tab navigation for this hint. Thus there is more accessibility.
|
|
Nopec
force-pushed
the
add-tab-navigation-in-untitled-hint
branch
from
03da67d to
09fc6b5
Compare
TylerLeonhardt
added
untitled-editor-hint
feature-request
maxwalts
approved these changes
Mar 30, 2023
|
Sorry for the delay here. It looks like there are some merge conflicts. If you'd still like to contribute, can you deal with those merge conflicts and we'll take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Description
When a new file is create a hint asks the user to specify the desired
programming language. This commit introduces a tab navigation for
this hint. Thus there is more accessibility.
This is my first PR and it fixes #132085. I didn't ask for permission to work on this, because I wasn't aware of how far I will get. But here is my code suggestion to this topic. If tests are needed, can you give me a hint where to place those? Also check the import order, maybe I have to alter something.
Covered use cases
Focus outline style for anchors matches other anchors
Tab navigation forth, back and selecting using enter
normal-tab-navigation.mov
Interrupting tab navigation by character input or click
interrupting-tab-navigation.mov
These buttons will not interrupt tab navigation: KeyCode.Tab, KeyCode.Enter, KeyCode.Shift, KeyCode.Ctrl,KeyCode.Alt and KeyCode.Meta.
Interrupting tab navigation by opening command palette
Shortcuts can be called while in tab navigation.
interrupting-tab-navigation-shortcuts.mov
Hopefully I didn't miss something and if you need more details feel free to ask. Thank you guys. 😁