Skip to content

terminal does not respect ECHO setting, resulting in displaying passwords on screen when using a slow remote connection #203388

Closed
@zygoloid

Description

Does this issue occur when all extensions are disabled?: No

  • VS Code Version: 1.85.1
  • OS Version: Debian testing

Steps to Reproduce:

  1. Create a remote SSH connection, to a machine with significant latency.
  2. Open interactive terminal.
  3. Enter a command that prompts for a password, such as ssh-add with a passphrase or sudo -s.

Expected result:

  • Password is not echoed to the screen.

Actual result:

  • Password is echoed to the screen temporarily, until remote responds to the keypresses, then password disappears again.

Presumably the interactive terminal is not correctly processing and respecting the ECHO terminal attribute that is intended to disable keyboard echo in circumstances such as this.

Perhaps respecting that attribute in general would be problematic, but maybe it should at least be respected when the current line contains words such as "password" or "passphrase"?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

*duplicateIssue identified as a duplicate of another issue(s)

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions