Move built-in extensions off vscode-nls
and on to the l10n
API #164438
Description
We have finalized the localization l10n
API 🎉 Since this API has been reviewed and tested a ton from non-built-in extensions, I thought it would be fitting to focus the finalization of this API on extensions that ship with VS Code. The goal here is to replace vscode-nls
's localize()
calls with the new vscode.l10n.t
calls.
Step 1: change the code
- Pick an extension that currently relies on
vscode-nls
(check package.json) and has somelocalize(
calls in it - migrate from the
vscode-nls
usage to the newvscode.l10n
API. I'm leaving this intentionally vague so you look at the typings to guide you on usage - Since you've now migrated an extension, you might as well submit a PR 😄
Step 2: testing the change
You can easily verify the English works by triggering some of strings you've changed and ensuring that they're still English and that parameters work and whatnot.
I wish I could have you test against an actual language, but that would be way too involved since you'd need to modify a Language Pack you have already installed (hacky) or wait for the PR to go in, and then wait for the translations to flow through and then wait for a Language Pack to be released.
I can go ahead and verify your changes once the PRs are in and the translations have flown to a released Language Pack.
Some examples: #164566 #163662
- html-language-features @aeschli
- json-language-features @aeschli
- css-language-features @aeschli
- debug-auto-launch @connor4312
- debug-server-ready @connor4312
- js-debug @connor4312
- emmet @rzhao271
- markdown-language-features @mjbvz
- media-preview @mjbvz
- simple-browser @mjbvz
- typescript-language-features @mjbvz
- php-language-features @roblourens
- references-view @jrieken
- configuration-editing @mjbvz
- extension-editing @mjbvz
- grunt @mjbvz
- gulp @mjbvz
- Jake @mjbvz
- merge-conflict @mjbvz
- npm @mjbvz
Activity