Skip to content

Move built-in extensions off vscode-nls and on to the l10n API #164438

Closed
microsoft/vscode-js-debug
#1515
@TylerLeonhardt

Description

We have finalized the localization l10n API 🎉 Since this API has been reviewed and tested a ton from non-built-in extensions, I thought it would be fitting to focus the finalization of this API on extensions that ship with VS Code. The goal here is to replace vscode-nls's localize() calls with the new vscode.l10n.t calls.

Step 1: change the code

  1. Pick an extension that currently relies on vscode-nls (check package.json) and has some localize( calls in it
  2. migrate from the vscode-nls usage to the new vscode.l10n API. I'm leaving this intentionally vague so you look at the typings to guide you on usage
  3. Since you've now migrated an extension, you might as well submit a PR 😄

Step 2: testing the change

You can easily verify the English works by triggering some of strings you've changed and ensuring that they're still English and that parameters work and whatnot.

I wish I could have you test against an actual language, but that would be way too involved since you'd need to modify a Language Pack you have already installed (hacky) or wait for the PR to go in, and then wait for the translations to flow through and then wait for a Language Pack to be released.

I can go ahead and verify your changes once the PRs are in and the translations have flown to a released Language Pack.

Some examples: #164566 #163662

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Labels

debtCode quality issuesl10n-platformLocalization platform issues (not wrong translations)

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions