Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve assertion when fixing VSTHRD103 #338

Merged
merged 2 commits into from
Aug 7, 2018
Merged

Preserve assertion when fixing VSTHRD103 #338

merged 2 commits into from
Aug 7, 2018

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Aug 5, 2018 •
edited
Loading

Fixes #328
Fixes #329

@sharwell sharwell changed the title Preserve assertion when fixing VSTHRD103 [In progress] Preserve assertion when fixing VSTHRD103 Aug 5, 2018
@sharwell sharwell changed the title [In progress] Preserve assertion when fixing VSTHRD103 Preserve assertion when fixing VSTHRD103 Aug 5, 2018
@AArnott
Copy link
Member

AArnott commented Aug 7, 2018

These look like important fixes. Can you rebase the PR to target v15.8?

@sharwell sharwell changed the base branch from master to v15.8 August 7, 2018 15:08
@sharwell sharwell force-pushed the preserve-assertion branch from 1b140ff to ad635ee Compare August 7, 2018 15:08
@sharwell
Copy link
Member Author

sharwell commented Aug 7, 2018

@AArnott rebase and retarget complete

@sharwell sharwell mentioned this pull request Aug 7, 2018
Merged
AArnott
AArnott approved these changes Aug 7, 2018
View reviewed changes
Copy link
Member

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AArnott AArnott merged commit 57e6bee into microsoft:v15.8 Aug 7, 2018
@AArnott AArnott added this to the v15.8 milestone Aug 7, 2018
@sharwell sharwell deleted the preserve-assertion branch August 7, 2018 16:38
@sharwell sharwell mentioned this pull request Aug 14, 2018
Closed
AArnott pushed a commit that referenced this pull request Jan 12, 2025
@renovate
Update nbgv and nerdbank.gitversioning updates to 3.7.115 (#338)
b47196d 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AArnott AArnott AArnott approved these changes

Assignees
No one assigned
Labels
analyzers
Projects
None yet
Milestone
v15.8
Development

Successfully merging this pull request may close these issues.
2 participants
@sharwell @AArnott