Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[POC|Invalid] Testing vcpkg without installed MSVC #42129

Draft
wants to merge 57 commits into
base: master
Choose a base branch
from
Draft

[POC|Invalid] Testing vcpkg without installed MSVC #42129

wants to merge 57 commits into from

Conversation

Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented Nov 12, 2024 •
edited
Loading

Hijacking x64-windows CI for this.

wished somebody would make Visual Studio truly portable. MSBuild looking up all those reg keys is a bit annoying.

No NETFXSDK installed.

Also what are all those different versions about and why don't any of those correlate to the folder version names.

Build system check:

  • cmake
  • autotools
  • meson
  • bazel
  • qmake (seems to just work)
  • msbuild (needs ENV{WindowsSDKVersion} fixed) fixed it here

Already pretty good:

development of failures 
SUMMARY FOR x64-windows
  SUCCEEDED: 2120
  BUILD_FAILED: 36
  POST_BUILD_CHECKS_FAILED: 10
  CASCADED_DUE_TO_MISSING_DEPENDENCIES: 225

SUMMARY FOR x64-windows
  SUCCEEDED: 2144
  BUILD_FAILED: 57
  POST_BUILD_CHECKS_FAILED: 9
  CASCADED_DUE_TO_MISSING_DEPENDENCIES: 182


SUMMARY FOR x64-windows
  SUCCEEDED: 2264
  BUILD_FAILED: 35
  POST_BUILD_CHECKS_FAILED: 9
  CASCADED_DUE_TO_MISSING_DEPENDENCIES: 90


SUMMARY FOR x64-windows
  SUCCEEDED: 2268
  BUILD_FAILED: 35
  POST_BUILD_CHECKS_FAILED: 9
  CASCADED_DUE_TO_MISSING_DEPENDENCIES: 89


 SUCCEEDED: 1464
  BUILD_FAILED: 26
  POST_BUILD_CHECKS_FAILED: 7
  CASCADED_DUE_TO_MISSING_DEPENDENCIES: 84

SUMMARY FOR x64-windows
  SUCCEEDED: 731
  BUILD_FAILED: 27
  CASCADED_DUE_TO_MISSING_DEPENDENCIES: 62

SUMMARY FOR x64-windows
  SUCCEEDED: 2314
  BUILD_FAILED: 27
  CASCADED_DUE_TO_MISSING_DEPENDENCIES: 61

SUMMARY FOR x64-windows
  SUCCEEDED: 2184
  BUILD_FAILED: 26
  POST_BUILD_CHECKS_FAILED: 1
  CASCADED_DUE_TO_MISSING_DEPENDENCIES: 16

Current Status:

SUMMARY FOR x64-windows
  SUCCEEDED: 2377
  BUILD_FAILED: 20
  POST_BUILD_CHECKS_FAILED: 2
  CASCADED_DUE_TO_MISSING_DEPENDENCIES: 2

@FrankXie05 FrankXie05 added the requires:testing Needs tests added before merging label Nov 13, 2024
Neumann-A
Neumann-A commented Nov 13, 2024
View reviewed changes
ports/msvc/portfile.cmake Outdated Show resolved Hide resolved
Neumann-A
Neumann-A commented Nov 13, 2024
View reviewed changes
ports/msvc/msvc-env.cmake Outdated Show resolved Hide resolved
@Neumann-A Neumann-A force-pushed the windows-triplet-without-installed-msvc branch from 7538913 to 13f4af9 Compare November 13, 2024 22:55
Neumann-A
Neumann-A commented Nov 14, 2024
View reviewed changes
ports/msvc/vcpkg.json Outdated Show resolved Hide resolved
Neumann-A
Neumann-A commented Nov 14, 2024
View reviewed changes
triplets/x64-windows.cmake Outdated Show resolved Hide resolved
@Neumann-A
Copy link
Contributor Author

Neumann-A commented Nov 17, 2024 •
edited
Loading

Already pretty good:

development of failures 
SUMMARY FOR x64-windows
  SUCCEEDED: 2120
  BUILD_FAILED: 36
  POST_BUILD_CHECKS_FAILED: 10
  CASCADED_DUE_TO_MISSING_DEPENDENCIES: 225

SUMMARY FOR x64-windows
  SUCCEEDED: 2144
  BUILD_FAILED: 57
  POST_BUILD_CHECKS_FAILED: 9
  CASCADED_DUE_TO_MISSING_DEPENDENCIES: 182


SUMMARY FOR x64-windows
  SUCCEEDED: 2264
  BUILD_FAILED: 35
  POST_BUILD_CHECKS_FAILED: 9
  CASCADED_DUE_TO_MISSING_DEPENDENCIES: 90


SUMMARY FOR x64-windows
  SUCCEEDED: 2268
  BUILD_FAILED: 35
  POST_BUILD_CHECKS_FAILED: 9
  CASCADED_DUE_TO_MISSING_DEPENDENCIES: 89


 SUCCEEDED: 1464
  BUILD_FAILED: 26
  POST_BUILD_CHECKS_FAILED: 7
  CASCADED_DUE_TO_MISSING_DEPENDENCIES: 84

SUMMARY FOR x64-windows
  SUCCEEDED: 731
  BUILD_FAILED: 27
  CASCADED_DUE_TO_MISSING_DEPENDENCIES: 62

SUMMARY FOR x64-windows
  SUCCEEDED: 2314
  BUILD_FAILED: 27
  CASCADED_DUE_TO_MISSING_DEPENDENCIES: 61

SUMMARY FOR x64-windows
  SUCCEEDED: 2184
  BUILD_FAILED: 26
  POST_BUILD_CHECKS_FAILED: 1
  CASCADED_DUE_TO_MISSING_DEPENDENCIES: 16

Current Status:

SUMMARY FOR x64-windows
  SUCCEEDED: 2377
  BUILD_FAILED: 20
  POST_BUILD_CHECKS_FAILED: 2
  CASCADED_DUE_TO_MISSING_DEPENDENCIES: 2

@Neumann-A
Copy link
Contributor Author

Neumann-A commented Nov 21, 2024 •
edited
Loading

Fix for using the Visual Studio Generator:

a) Install /VC/Auxiliary/Build/Microsoft.VCToolsVersion.default.txt from the v143 version
b)

   set(CMAKE_GENERATOR_INSTANCE "${_VCPKG_INSTALLED_DIR}/${VCPKG_TARGET_TRIPLET}/VS/,version=17.12.35410.122" CACHE INTERNAL "")
   set(CMAKE_VS_VERSION_BUILD_NUMBER 17.12.35410.122)

c) list(APPEND CMAKE_TRY_COMPILE_PLATFORM_VARIABLES _VCPKG_INSTALLED_DIR) (for setting CMAKE_GENERATOR_INSTANCE)
d) Update CMake v3.31.0

@Neumann-A Neumann-A mentioned this pull request Dec 4, 2024
Closed
7 tasks
@Neumann-A
Copy link
Contributor Author

@dg0yt I see a few test ports failing here due to missing debug stuff. You probably know better than me how to easily make them single config compatible.

@Neumann-A
Copy link
Contributor Author

@dg0yt: Got a new tab for your bazel toolchain tabs: https://pigweed.dev/docs/blog/06-better-cpp-toolchains.html

@Neumann-A
Copy link
Contributor Author

cppmicrososervices: Wrong usage of PRIVATE_HEADERS
physx: single config issue
pdcurse: nmake -> needs to be investigated.

@Neumann-A
Merge remote-tracking branch 'upstream/master' into windows-triplet-w…
7627178 
…ithout-installed-msvc

# Conflicts:
#	ports/g2o/portfile.cmake
#	ports/mongo-c-driver/vcpkg.json
@Neumann-A
Merge branch 'windows-triplet-without-installed-msvc' of https://gith…
89c261e 
…ub.com/Neumann-A/vcpkg into windows-triplet-without-installed-msvc
@Neumann-A
fix abs path
23b5965
@Neumann-A
fix pdcurses
12bb0dc
@Neumann-A
more fixes
ad2ab67
@Neumann-A
fix a few failures
312720c
@Neumann-A
fix g2o
866e7d5
@Neumann-A
Merge remote-tracking branch 'upstream/master' into windows-triplet-w…
eeb2cf9 
…ithout-installed-msvc
@Neumann-A
fix openmvg
4091ec1
@Neumann-A
abs path fix
130bebb
@Neumann-A
fix patch
24952b2
@Neumann-A
Merge remote-tracking branch 'upstream/master' into windows-triplet-w…
e6db172 
…ithout-installed-msvc

# Conflicts:
#	ports/cppmicroservices/devendor_boost_absl.patch
#	ports/crashpad/vcpkg.json
#	ports/curlpp/portfile.cmake
#	ports/fltk/portfile.cmake
#	ports/g2o/fix-absolute.patch
#	ports/krb5/vcpkg.json
#	ports/physx/portfile.cmake
#	ports/usd/vcpkg.json
@Neumann-A Neumann-A mentioned this pull request Jan 3, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@FrankXie05 FrankXie05

Labels
requires:testing Needs tests added before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Neumann-A @dg0yt @FrankXie05