Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Webthing-CPP] add new port #41669

Merged
merged 10 commits into from
Oct 23, 2024
Merged

Conversation

bw-hro
Copy link
Contributor

@bw-hro bw-hro commented Oct 20, 2024

Webthing-CPP is a modern CPP/C++17 implementation of the WebThings API.

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@Cheney-W Cheney-W added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Oct 21, 2024
@Cheney-W
Copy link
Contributor

Webthing-CPP is a header-only repository, so please refer to the contents of the following files to modify the files of Webthing-CPP:
https://github.com/microsoft/vcpkg/blob/master/ports/cimg/vcpkg.json
https://github.com/microsoft/vcpkg/blob/master/ports/cimg/portfile.cmake

@Cheney-W Cheney-W marked this pull request as draft October 21, 2024 09:45
@bw-hro bw-hro marked this pull request as ready for review October 21, 2024 20:38
@Cheney-W Cheney-W marked this pull request as draft October 22, 2024 05:47
bw-hro and others added 3 commits October 22, 2024 09:00
Co-authored-by: Cheney Wang <38240633+Cheney-W@users.noreply.github.com>
Co-authored-by: Cheney Wang <38240633+Cheney-W@users.noreply.github.com>
Cheney-W
Cheney-W previously approved these changes Oct 22, 2024
@bw-hro
Copy link
Contributor Author

bw-hro commented Oct 22, 2024

Hi, Cheney thank you very much for your support. All tests now appear to have been completed and passed. Is anything else missing?

@bw-hro bw-hro marked this pull request as ready for review October 22, 2024 12:21
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Oct 23, 2024
@Cheney-W
Copy link
Contributor

Usage test passed with x64-windows triplet.

@Cheney-W
Copy link
Contributor

There is nothing else. I think this pr just needs to wait to be merged.

@data-queue data-queue merged commit 3447aa6 into microsoft:master Oct 23, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants