[hwinfo] add new port #40637
[hwinfo] add new port #40637
Conversation
|
@microsoft-github-policy-service agree |
@microsoft-github-policy-service agree |
jimwang118
added
the
category:new-port
|
@jimwang118 Why x86_windows failed? I dont know what happend with ci log. |
|
Usage test pass with following triplet: |
ports/hwinfo/usage
Outdated
| hwinfo provides CMake targets : | ||
| # this is heuristically generated, and may not be correct | ||
| find_package(hwinfo CONFIG REQUIRED) | ||
| target_link_libraries(main PRIVATE hwinfo::hwinfo) | ||
|
|
There was a problem hiding this comment.
| hwinfo provides CMake targets : | |
| # this is heuristically generated, and may not be correct | |
| find_package(hwinfo CONFIG REQUIRED) | |
| target_link_libraries(main PRIVATE hwinfo::hwinfo) | |
| hwinfo provides CMake targets: | |
| find_package(hwinfo CONFIG REQUIRED) | |
| target_link_libraries(main PRIVATE hwinfo::hwinfo) |
The heuristical output uses this formatting.
And when you add an explicit usage file, I would expected that you actually validated it. So it doesn't need a hint about being "heuristically generated".
(You don't have to add this file if the heuristics does a good job.)
|
I think this is the wrong library using the name hwinfo. I think here happened the same as in #35465 which was then reverted in #35993. Therefore may quote @dg0yt here:
|
|
Sorry, i search hwinfo in Browse packages and there is not port named hwinfo, so i add it. Should i change name in this pr? |
You open a new PR and change the port name. |
This reverts commit dfa8003.
find_packagecalls are REQUIRED, are satisfied byvcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.