[vcpkg] Improve error reporting for vcpkg_abi_info.txt copy failure. #15871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In build https://dev.azure.com/vcpkg/public/_build/results?buildId=48398 we are getting output like: ``` Error: Building package v-hacd:x64-windows-static failed with: BUILD_FAILED Elapsed time for package v-hacd:x64-windows-static: 4.156 s Starting package 1396/1464: v8:x64-windows-static Building package v8[core]:x64-windows-static... -- Using msys root at D:/downloads/tools/msys2/969c0913b9df89e1 -- Fetching https://chromium.googlesource.com/v8/v8.git... CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:108 (message): Command failed: C:/agent/externals/git/cmd/git.exe fetch https://chromium.googlesource.com/v8/v8.git 7565e93eb72cea4268028fc20186d415c22b1cff --depth 1 -n Working Directory: D:/downloads/git-tmp Error code: 128 See logs for more information: D:\buildtrees\v8\git-fetch-x64-windows-static-err.log Call Stack (most recent call first): scripts/cmake/vcpkg_from_git.cmake:91 (vcpkg_execute_required_process) ports/v8/portfile.cmake:71 (vcpkg_from_git) scripts/ports.cmake:128 (include) Could not copy into file: D:\packages\v8_x64-windows-static\share\v8\vcpkg_abi_info.txt ``` but aren't printing the reason for the copy failure. Added printing of that reason.
BillyONeal
added
category:vcpkg-bug
strega-nil
approved these changes
Jan 25, 2021
toolsrc/src/vcpkg/build.cpp
Outdated
Comment on lines
1213
to
1216
| Strings::format("Could not create %s: %d %s", | ||
| fs::u8string(abi_package_dir).c_str(), | ||
| ec.value(), | ||
| ec.message().c_str())); |
There was a problem hiding this comment.
Suggested change
| Strings::format("Could not create %s: %d %s", | |
| fs::u8string(abi_package_dir).c_str(), | |
| ec.value(), | |
| ec.message().c_str())); | |
| Strings::format("Could not create %s: %s (%d)", | |
| fs::u8string(abi_package_dir), | |
| ec.message(), | |
| ec.value())); |
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
…icrosoft#15871) In build https://dev.azure.com/vcpkg/public/_build/results?buildId=48398 we are getting output like: ``` Error: Building package v-hacd:x64-windows-static failed with: BUILD_FAILED Elapsed time for package v-hacd:x64-windows-static: 4.156 s Starting package 1396/1464: v8:x64-windows-static Building package v8[core]:x64-windows-static... -- Using msys root at D:/downloads/tools/msys2/969c0913b9df89e1 -- Fetching https://chromium.googlesource.com/v8/v8.git... CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:108 (message): Command failed: C:/agent/externals/git/cmd/git.exe fetch https://chromium.googlesource.com/v8/v8.git 7565e93eb72cea4268028fc20186d415c22b1cff --depth 1 -n Working Directory: D:/downloads/git-tmp Error code: 128 See logs for more information: D:\buildtrees\v8\git-fetch-x64-windows-static-err.log Call Stack (most recent call first): scripts/cmake/vcpkg_from_git.cmake:91 (vcpkg_execute_required_process) ports/v8/portfile.cmake:71 (vcpkg_from_git) scripts/ports.cmake:128 (include) Could not copy into file: D:\packages\v8_x64-windows-static\share\v8\vcpkg_abi_info.txt ``` but aren't printing the reason for the copy failure. Added printing of that reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In build https://dev.azure.com/vcpkg/public/_build/results?buildId=48398
we are getting output like:
(followed by a crash of vcpkg)
but aren't printing the reason for the copy failure. Added printing of that reason.