[heft-typescript-plugin] feat: support typescript 5.6 #4972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UberMouse
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
UberMouse
force-pushed
the
heft-typescript-plugin-typescript-56-support
branch
from
0e630d6 to
30caeba
Compare
|
Hmm, seems obvious now but the CI doesn't work because the change only functions when tested against a typescript 5.6 based compiler but rushstack repo is on an older typescript version 🤷 Anyway, I'll leave this here as an example |
jakebailey
reviewed
Oct 14, 2024
UberMouse
force-pushed
the
heft-typescript-plugin-typescript-56-support
branch
from
30caeba to
a8d78bc
Compare
jakebailey
reviewed
Oct 14, 2024
...ck/heft-typescript-plugin/heft-typescript-plugin-typescript-56-support_2024-10-13-22-44.json
Outdated
Show resolved
Hide resolved
UberMouse
force-pushed
the
heft-typescript-plugin-typescript-56-support
branch
from
a8d78bc to
29b45e4
Compare
There was a problem hiding this comment.
You should also update the "newest compatible version" constants here:
rushstack/heft-plugins/heft-typescript-plugin/src/TypeScriptBuilder.ts
Lines 113 to 114 in 239ad8a
Assuming this works with 5.5 and 5.6
This is a breaking change and will not work on Typescript versions < 5.6
iclanton
approved these changes
Oct 15, 2024
UberMouse
force-pushed
the
heft-typescript-plugin-typescript-56-support
branch
from
29b45e4 to
aca28b9
Compare
|
Updated |
dmichon-msft
approved these changes
Oct 15, 2024
D4N14L
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the heft typescript plugin for breaking changes made to the typescript internals that the plugin relies on
Details
The breakage was caused by an internal change of
BuilderProgram.getState()toBuilderProgram.statein this commit.Changing the code to use
.stateinstead of.getState()ifstateis defined was the only change requiredFixes #4921
How it was tested
Linked into our monorepo and a full build of all packages was done
Then everything was started in watch mode and a webpack based package was started up to verify that watch mode changes are still picked up correctly
Our monorepo does not use heft for linting so I haven't tested if this change still works correctly with the heft lint plugin
Impacted documentation