[rush] Look for :incremental suffixed scripts in watch mode
#4960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmichon-msft
requested review from
iclanton,
octogonz,
apostolisms and
D4N14L
as code owners
D4N14L
approved these changes
Oct 3, 2024
iclanton
approved these changes
Oct 3, 2024
libraries/rush-lib/src/logic/operations/IPCOperationRunnerPlugin.ts
Outdated
Show resolved
Hide resolved
libraries/rush-lib/src/logic/operations/ShardedPhaseOperationPlugin.ts
Outdated
Show resolved
Hide resolved
libraries/rush-lib/src/logic/operations/ShellOperationRunnerPlugin.ts
Outdated
Show resolved
Hide resolved
libraries/rush-lib/src/logic/operations/ShellOperationRunnerPlugin.ts
Outdated
Show resolved
Hide resolved
dmichon-msft
force-pushed
the
script-priority
branch
from
522c11e to
2597a39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes the algorithm for executing phased commands in watch mode to prefer a script named
_phase:<name>:incrementalfor every iteration after the first. The typical scenario for such would be to omit cleaning from an incremental run.Details
The build cache will still treat the
:incrementalcommands as having the same cache key as the non-incremental command, so later iterations can still encounter cache hits. However, cache writes do not occur in iterations after the first.How it was tested
Temporarily added a
_phase:build:incrementalto a project and ranrush start. Validated that the_phase:build:incrementalscript was used for the second iteration. Validated that modifying inputs back to a state known to be present in the cache resulted in a cache hit.Impacted documentation
Documentation on phased commands.