Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush-sdk] Expose file change analysis on the ProjectChangeAnalyzer class #4959

Merged
merged 15 commits into from
Oct 3, 2024

Conversation

D4N14L
Copy link
Member

@D4N14L D4N14L commented Oct 2, 2024

Summary

This change exposes file change analysis on the ProjectChangeAnalyzer class. This will allow for consumers of this class to perform additional analysis on the underlying file changes that the ProjectChangeAnalyzer uses to determine if a project is modified or otherwise.

It also adds a LookupByPath.groupByChild method to group a map of [paths -> info] by the nearest child in the LookupByPath trie.

@D4N14L D4N14L requested a review from patmill as a code owner October 2, 2024 20:46
Copy link
Contributor

@dmichon-msft dmichon-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests would be nice, but otherwise this works.

libraries/rush-lib/src/logic/ProjectChangeAnalyzer.ts Outdated Show resolved Hide resolved
@D4N14L D4N14L enabled auto-merge (squash) October 3, 2024 00:42
@D4N14L D4N14L merged commit 0d2d532 into microsoft:main Oct 3, 2024
4 checks passed
@iclanton iclanton deleted the user/danade/ExposeFileChangeAnalysis branch October 3, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants