-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rush-sdk] Expose file change analysis on the ProjectChangeAnalyzer
class
#4959
Merged
D4N14L
merged 15 commits into
microsoft:main
from
D4N14L:user/danade/ExposeFileChangeAnalysis
Oct 3, 2024
Merged
[rush-sdk] Expose file change analysis on the ProjectChangeAnalyzer
class
#4959
D4N14L
merged 15 commits into
microsoft:main
from
D4N14L:user/danade/ExposeFileChangeAnalysis
Oct 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D4N14L
requested review from
iclanton,
octogonz,
apostolisms and
dmichon-msft
as code owners
October 2, 2024 19:15
…er/danade/ExposeFileChangeAnalysis
dmichon-msft
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit tests would be nice, but otherwise this works.
dmichon-msft
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change exposes file change analysis on the
ProjectChangeAnalyzer
class. This will allow for consumers of this class to perform additional analysis on the underlying file changes that theProjectChangeAnalyzer
uses to determine if a project is modified or otherwise.It also adds a
LookupByPath.groupByChild
method to group a map of [paths -> info] by the nearest child in theLookupByPath
trie.