Implement SARIF formatter for Eslint #4956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atingmicrosoft
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L,
dmichon-msft and
patmill
as code owners
atingmicrosoft
force-pushed
the
ating/eslint-sarif-formatter
branch
from
25c5e8a to
4f03791
Compare
D4N14L
reviewed
Oct 1, 2024
heft-plugins/heft-lint-plugin/src/schemas/heft-lint-plugin.schema.json
Outdated
Show resolved
Hide resolved
dmichon-msft
reviewed
Oct 1, 2024
…lint to version 18.56.10
…to ating/eslint-sarif-formatter
…to ating/eslint-sarif-formatter
D4N14L
reviewed
Oct 3, 2024
…to ating/eslint-sarif-formatter
D4N14L
reviewed
Oct 4, 2024
eslint/eslint-patch/src/eslint-bulk-suppressions/cli/runEslint.ts
Outdated
Show resolved
Hide resolved
D4N14L
approved these changes
Oct 5, 2024
dmichon-msft
reviewed
Oct 7, 2024
eslint/eslint-patch/src/eslint-bulk-suppressions/cli/runEslint.ts
Outdated
Show resolved
Hide resolved
heft-plugins/heft-lint-plugin/src/schemas/heft-lint-plugin.schema.json
Outdated
Show resolved
Hide resolved
dmichon-msft
reviewed
Oct 7, 2024
dmichon-msft
approved these changes
Oct 7, 2024
iclanton
reviewed
Oct 7, 2024
common/changes/@rushstack/eslint-patch/ating-eslint-sarif-formatter_2024-10-02-21-04.json
Outdated
Show resolved
Hide resolved
iclanton
reviewed
Oct 7, 2024
...changes/@rushstack/eslint-plugin-packlets/ating-eslint-sarif-formatter_2024-10-02-21-04.json
Outdated
Show resolved
Hide resolved
...changes/@rushstack/eslint-plugin-security/ating-eslint-sarif-formatter_2024-10-02-21-04.json
Outdated
Show resolved
Hide resolved
common/changes/@rushstack/eslint-plugin/ating-eslint-sarif-formatter_2024-10-02-21-04.json
Outdated
Show resolved
Hide resolved
heft-plugins/heft-lint-plugin/src/schemas/heft-lint-plugin.schema.json
Outdated
Show resolved
Hide resolved
common/changes/@rushstack/heft-lint-plugin/ating-eslint-sarif-formatter_2024-10-01-21-31.json
Outdated
Show resolved
Hide resolved
iclanton
reviewed
Oct 7, 2024
iclanton
reviewed
Oct 7, 2024
iclanton
reviewed
Oct 8, 2024
common/changes/@rushstack/eslint-patch/ating-eslint-sarif-formatter_2024-10-02-21-04.json
Outdated
Show resolved
Hide resolved
...changes/@rushstack/eslint-plugin-packlets/ating-eslint-sarif-formatter_2024-10-02-21-04.json
Outdated
Show resolved
Hide resolved
...changes/@rushstack/eslint-plugin-security/ating-eslint-sarif-formatter_2024-10-02-21-04.json
Outdated
Show resolved
Hide resolved
common/changes/@rushstack/eslint-plugin/ating-eslint-sarif-formatter_2024-10-02-21-04.json
Outdated
Show resolved
Hide resolved
heft-plugins/heft-lint-plugin/src/test/__snapshots__/snapshot.test.ts.snap
Outdated
Show resolved
Hide resolved
heft-plugins/heft-lint-plugin/src/test/__snapshots__/snapshot.test.ts.snap
Outdated
Show resolved
Hide resolved
iclanton
reviewed
Oct 8, 2024
…fact indicies. Added more snapshot tests. URL tracked in sariff formatter are relative vs absolute. Rules Meta now included in sarif file
iclanton
reviewed
Oct 9, 2024
heft-plugins/heft-lint-plugin/src/test/__snapshots__/SarifFormatter.test.ts.snap
Outdated
Show resolved
Hide resolved
heft-plugins/heft-lint-plugin/src/test/__snapshots__/SarifFormatter.test.ts.snap
Outdated
Show resolved
Hide resolved
iclanton
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Create ability for Eslint to create SARIF files.
Details
ESlint can now ccreate SARIF files by specifiying it in a projects heft.json that contains an eslintrc file.
How it was tested
Tested it by building packages with an eslintrc file and specifying the heft.json file to create a SARIF file.
Impacted documentation