Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS][Build] Add Headers and Copy Files build phases #665

Merged
merged 2 commits into from
Jan 20, 2017
Merged

[iOS][Build] Add Headers and Copy Files build phases #665

merged 2 commits into from
Jan 20, 2017

Conversation

sergey-akhalkov
Copy link
Contributor

Due to changes in new release of react-native@0.40.0 there is CodePush.h file not found error occures.
To fix it I've added CodePush.h header file in Headers build phase and changed
codePushHeaderImportStatement variable value from #import "CodePush.h"
to #import <CodePush/CodePush.h> in postlink.js file.
Fix #662

@msftclas
Copy link

msftclas commented Jan 9, 2017

Hi @sergey-akhalkov, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@vladimir-kotikov
Copy link

/cc @BretJohnson

@panarasi
Copy link

panarasi commented Jan 9, 2017

@sergey-akhalkov @BretJohnson Should this not have a phase to Copy Headers too ? I tried running it, the headers were included, but header was not copied over to /Users/mYName/Library/Developer/Xcode/DerivedData/MYPROJ/Build/Products/Debug-iphonesimulator/include/CodePush/CodePush.a

@jy1989
Copy link

jy1989 commented Jan 10, 2017

hi I've tried to get your modified sources and replace in my project. but the error still there. is it need to do some setup in my project?

@sergey-akhalkov
Copy link
Contributor Author

sergey-akhalkov commented Jan 10, 2017 •
edited
Loading

@panarasi, @jy1989 - hi!
I've updated PR and tested it with newly created React Native apps having react-native versions v0.39.2 and v0.40.0 and now it should work, please verify.

@sergey-akhalkov
[iOS][Build] Add Headers and Copy Files build phases
39fa940 
Due to changes in new release of `react-native@0.40.0`
there is `CodePush.h file not found` error occures.
To fix it I've added `CodePush.h` header file in `Headers`
and `Copy Files` build phases and changed
`codePushHeaderImportStatement` variable value from `#import "CodePush.h"`
to `#import <CodePush/CodePush.h>` in `postlink.js` file.
Fix #662
@sergey-akhalkov sergey-akhalkov changed the title [iOS][Build] Add Headers build phase [iOS][Build] Add Headers and Copy Files build phases Jan 10, 2017
@axemclion axemclion mentioned this pull request Jan 10, 2017
Closed
@sergey-akhalkov sergey-akhalkov mentioned this pull request Jan 11, 2017
Closed
@christopherdro christopherdro mentioned this pull request Jan 12, 2017
Merged
@sergey-akhalkov
readme: update iOS manual plugin installation/usage documentation
4edd6a1 
Due to changes in React Native v0.40.0 and changes in CodePush project Step 6. of iOS manual plugin installation (add “Header Search Paths”) is not needed anymore. Also changed path to `CodePush.h` file in `AppDelegate.m` to `#import <CodePush/CodePush.h>`
@buptkang
Copy link
Contributor

I test this PR with @Silhouettes, and it works well.

@buptkang buptkang merged commit 90f0bb8 into microsoft:master Jan 20, 2017
@buptkang buptkang mentioned this pull request Jan 24, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'CodePush.h' file not found
6 participants
@sergey-akhalkov @msftclas @vladimir-kotikov @panarasi @jy1989 @buptkang