Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rn 0.38 #624

Merged
merged 3 commits into from
Nov 28, 2016
Merged

Upgrade to rn 0.38 #624

merged 3 commits into from
Nov 28, 2016

Conversation

buptkang
Copy link
Contributor

There is no issues detected by using RN 0.38 instead of previous RN 0.37. Only readme file is updated.

@msftclas
Copy link

Hi @buptkang, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Bo Kang). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Copy link
Contributor

@richardhuaaa richardhuaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing to fix but looks good to me otherwise!

@@ -103,7 +103,7 @@ class CodePushDemoApp extends Component {
return (
<View style={styles.container}>
<Text style={styles.welcome}>
Welcome to CodePush!
Welcome to CodePush, test.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to remove the test addition here

@buptkang buptkang merged commit 76b4f4d into master Nov 28, 2016
@sergey-akhalkov sergey-akhalkov deleted the upgrade-rn-38 branch January 9, 2018 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants