Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dump_bin #1273

Merged
merged 1 commit into from
Nov 4, 2022
Merged

fix dump_bin #1273

merged 1 commit into from
Nov 4, 2022

Conversation

lerit
Copy link
Contributor

@lerit lerit commented Aug 31, 2022

dump_fix data that not in calendar_list, throw error:

NaT is not in list

if first data with dump_all like:

date,open
2000-01-04,111
2000-01-05,222
2000-01-06,333

and then second with dump_fix like:

date,open
2000-01-01,111
2000-01-02,222
2000-01-03,333

it will cause _df to be empty,and cause error(because df not in calendar_list range):

_df = self.data_merge_calendar(df, calendar_list)

i know even this pull request ,old data still not be update to bin,it just a way to catch and give message for such data

dump_fix data that not in calendar_list, throw error:
```
NaT is not in list
```
@you-n-g
Copy link
Collaborator

you-n-g commented Nov 4, 2022

Thanks! It looks great.
Welcome to become one of Qlib's contributors

@you-n-g you-n-g merged commit 2fae407 into microsoft:main Nov 4, 2022
@you-n-g you-n-g added the bug Something isn't working label Dec 9, 2022
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
dump_fix data that not in calendar_list, throw error:
```
NaT is not in list
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants