Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix plotImage and showImage behavior in the sim #387

Merged
merged 3 commits into from
Apr 21, 2017
Merged

Fix plotImage and showImage behavior in the sim #387

merged 3 commits into from
Apr 21, 2017

Conversation

riknoll
Copy link
Member

@riknoll riknoll commented Apr 20, 2017

Tested on hardware. Both plotImage() and showImage() respect the animation queue. The difference is that showImage() is async and lets you specify a delay.

@riknoll riknoll requested review from pelikhan and tballmsft April 20, 2017 23:48
tballmsft
tballmsft approved these changes Apr 21, 2017
View reviewed changes
Copy link
Contributor

@tballmsft tballmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@pelikhan pelikhan merged commit 43bad88 into master Apr 21, 2017
@pelikhan pelikhan deleted the animation_queue branch April 21, 2017 16:01
@lock
Copy link

lock bot commented Sep 26, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tballmsft tballmsft tballmsft approved these changes

@pelikhan pelikhan Awaiting requested review from pelikhan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@riknoll @tballmsft @pelikhan