Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable some features to improve the programming experience #1022

Merged
merged 3 commits into from
May 18, 2023

Conversation

THEb0nny
Copy link
Contributor

Enable addNewTypeScriptFile so that you can split your code into multiple files. Enable blocksCollapsing to collapse blocks for convenience. Turn off highContrast it doesn't work now. We'll see later...

All enabled options work.

THEb0nny added 2 commits May 11, 2023 11:13
Enable addNewTypeScriptFile so that you can split your code into multiple files. Enable blocksCollapsing to collapse blocks for convenience. Turn off highContrast it doesn't work now. We'll see later...
@THEb0nny
Copy link
Contributor Author

Also added the errorList option. Works.

@THEb0nny
Copy link
Contributor Author

@jwunderl please see the changes.

Copy link
Member

@jwunderl jwunderl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm besides the high contrast chnage~

pxtarget.json Outdated Show resolved Hide resolved
Co-authored-by: Joey Wunderlich <jwunderl@users.noreply.github.com>
@THEb0nny
Copy link
Contributor Author

THEb0nny commented May 11, 2023

lgtm besides the high contrast chnage~

Ok, I'll wait for the build.

@THEb0nny THEb0nny requested a review from jwunderl May 11, 2023 19:29
@THEb0nny
Copy link
Contributor Author

@jwunderl please see changes

@jwunderl jwunderl merged commit 6d222c5 into microsoft:master May 18, 2023
@jwunderl
Copy link
Member

Thanks!

@THEb0nny THEb0nny deleted the pxtarget-update branch May 30, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants