Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended show screen blocks options #1019

Merged
merged 8 commits into from
May 5, 2023

Conversation

THEb0nny
Copy link
Contributor

@THEb0nny THEb0nny commented May 4, 2023

Similar blocks have been created, in which the ability to select the place to print horizontally (columns) has been added, as well as the choice of printing mode black text on a white background and white text on a black background.

Old blocks are deprecated.

Convert old blocks to obsolete ones, new blocks differ in that you can specify the place to start printing along the horizontal axis of the screen (column). And also added a print style. These are the standard black text on a white background and the new white text on a black background. These two parameters are optionally expanded and optional, by default column = 1 and the print style is the same as before, black text on white.
@THEb0nny
Copy link
Contributor Author

THEb0nny commented May 4, 2023

image

@THEb0nny THEb0nny changed the title Extended display options Extended show blocks options May 4, 2023
@THEb0nny THEb0nny changed the title Extended show blocks options Extended show screen blocks options May 5, 2023
@pelikhan pelikhan requested a review from jwunderl May 5, 2023 12:22
Copy link
Member

@jwunderl jwunderl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, some small tweaks on the blocks

libs/screen/targetoverrides.ts Outdated Show resolved Hide resolved
libs/screen/targetoverrides.ts Outdated Show resolved Hide resolved
libs/screen/targetoverrides.ts Outdated Show resolved Hide resolved
libs/screen/targetoverrides.ts Outdated Show resolved Hide resolved
THEb0nny and others added 5 commits May 6, 2023 01:38
Co-authored-by: Joey Wunderlich <jwunderl@users.noreply.github.com>
Co-authored-by: Joey Wunderlich <jwunderl@users.noreply.github.com>
Co-authored-by: Joey Wunderlich <jwunderl@users.noreply.github.com>
Co-authored-by: Joey Wunderlich <jwunderl@users.noreply.github.com>
@jwunderl jwunderl merged commit 7625777 into microsoft:master May 5, 2023
@jwunderl
Copy link
Member

jwunderl commented May 5, 2023

Thanks! Will merge a few more then bump beta

@THEb0nny THEb0nny deleted the show-screen-blocks-empowerment branch May 6, 2023 10:16
@THEb0nny
Copy link
Contributor Author

It turned out that only the white font works in the simulator. On the controller, filling with a black background works, but the text is not displayed in white. I will work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants