-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a none option to the simulator for the color sensor and colorEnumPicker extension #1018
Add a none option to the simulator for the color sensor and colorEnumPicker extension #1018
Conversation
If you first select any color, and then click on it a second time, then none is activated and the selection also goes to it. |
Added option to select emptiness (nothing) for the colorEnumPicker block.
I think there is no way to change the signature for these blocks, it displays the hex code. |
Set new names for colored cells that pops up when hovering over an element. So the user will understand the color.
@jwunderl see changes please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 typo + one clarifying question
Co-authored-by: Joey Wunderlich <jwunderl@users.noreply.github.com>
I changed gray to brown but didn't have time to send? |
Ah sorry, merged to prep a beta build before I'm out for the day (/v1.4.32 should be up in about 5 minutes), feel free to file as a separate pr -- I'll have to read through the file one more time anyways to make sure it won't mess up block upgrades / etc |
Add a void option to the simulator for the color sensor.
Now emptiness can be chosen non-intuitively. There is no option. But, if you click on the circle with the selected color again, then the none option is activated, I think that this is not clear to users, so I added a separate circle.