Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a none option to the simulator for the color sensor and colorEnumPicker extension #1018

Merged

Conversation

THEb0nny
Copy link
Contributor

@THEb0nny THEb0nny commented May 3, 2023

Add a void option to the simulator for the color sensor.
Now emptiness can be chosen non-intuitively. There is no option. But, if you click on the circle with the selected color again, then the none option is activated, I think that this is not clear to users, so I added a separate circle.

@THEb0nny THEb0nny changed the title Update colorGrid.ts Add a none option to the simulator for the color sensor May 3, 2023
@THEb0nny
Copy link
Contributor Author

THEb0nny commented May 3, 2023

image

@THEb0nny
Copy link
Contributor Author

THEb0nny commented May 3, 2023

If you first select any color, and then click on it a second time, then none is activated and the selection also goes to it.

Added option to select emptiness (nothing) for the colorEnumPicker block.
@THEb0nny
Copy link
Contributor Author

THEb0nny commented May 4, 2023

Added option to select emptiness (nothing) for the colorEnumPicker block.

image

@THEb0nny
Copy link
Contributor Author

THEb0nny commented May 4, 2023

I think there is no way to change the signature for these blocks, it displays the hex code.

@THEb0nny
Copy link
Contributor Author

THEb0nny commented May 4, 2023

It would be nice if the absence of color displayed as transparency...
image

@THEb0nny THEb0nny changed the title Add a none option to the simulator for the color sensor Add a none option to the simulator for the color sensor and colorEnumPicker extension May 4, 2023
Set new names for colored cells that pops up when hovering over an element. So the user will understand the color.
@THEb0nny
Copy link
Contributor Author

THEb0nny commented May 4, 2023

I changed the code so that the color names are displayed in the popup window (title attribute) instead of the hex codes.

image

image

image

image

@THEb0nny
Copy link
Contributor Author

THEb0nny commented May 4, 2023

@jwunderl see changes please

Copy link
Member

@jwunderl jwunderl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 typo + one clarifying question

sim/visuals/controls/colorGrid.ts Outdated Show resolved Hide resolved
sim/visuals/controls/colorGrid.ts Show resolved Hide resolved
Co-authored-by: Joey Wunderlich <jwunderl@users.noreply.github.com>
@jwunderl jwunderl merged commit fba924d into microsoft:master May 5, 2023
@THEb0nny
Copy link
Contributor Author

THEb0nny commented May 5, 2023

I changed gray to brown but didn't have time to send?

@jwunderl
Copy link
Member

jwunderl commented May 5, 2023

Ah sorry, merged to prep a beta build before I'm out for the day (/v1.4.32 should be up in about 5 minutes), feel free to file as a separate pr -- I'll have to read through the file one more time anyways to make sure it won't mess up block upgrades / etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants