Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test runner): respect updateSourceMethod from the config #34442

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix(test runner): respect updateSourceMethod from the config #34442

merged 1 commit into from
Jan 23, 2025

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Jan 23, 2025

It was always set to patch from the CLI.

@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 1"

5 flaky ⚠️ [firefox-library] › tests/library/page-clock.spec.ts:282:3 › stubTimers › replaces global performance.timeOrigin @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-2.spec.ts:93:7 › cli codegen › should not lead to an error if html gets clicked @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:93:11 › should proxy local network requests › by default › link-local @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-set-input-files.spec.ts:147:3 › should upload large file @webkit-ubuntu-22.04-node18

37623 passed, 648 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit ab3b4b8 into microsoft:main Jan 23, 2025
29 checks passed
dgozman added a commit to dgozman/playwright that referenced this pull request Jan 23, 2025
@dgozman
cherry-pick(microsoft#34442): fix(test runner): respect updateSourceM…
12ee593 
…ethod from the config
dgozman added a commit that referenced this pull request Jan 23, 2025
@dgozman
cherry-pick(#34442): fix(test runner): respect updateSourceMethod fro…
5d6ac96 
…m the config (#34445)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxschmitt mxschmitt mxschmitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgozman @mxschmitt