Symmetric quantized convolution kernel ARM64 #9772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yufenglee
reviewed
Nov 16, 2021
yufenglee
reviewed
Nov 16, 2021
chenfucn
force-pushed
the
cfu_qconv
branch
6 times, most recently
from
3c70547 to
252d28a
Compare
chenfucn
force-pushed
the
cfu_qconv
branch
14 times, most recently
from
b640e22 to
f6f0519
Compare
chenfucn
force-pushed
the
cfu_qconv
branch
4 times, most recently
from
50fd111 to
5efe775
Compare
yufenglee
reviewed
Dec 7, 2021
yufenglee
reviewed
Dec 7, 2021
yufenglee
reviewed
Dec 7, 2021
yufenglee
reviewed
Dec 7, 2021
yufenglee
reviewed
Dec 8, 2021
chenfucn
force-pushed
the
cfu_qconv
branch
5 times, most recently
from
adc10fb to
94184bc
Compare
yufenglee
reviewed
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Describe your changes.
Adding a symmetric quantized convolution kernel for ARM64
Pre-dot CPU (Pixel 3a)
Post-dot CPU (Pixel 5a)
Note:
Indirect conv performs worse for shallow convs (input channels are small). This is much more so for low end pre-dot CPUs, where only 128 or deeper conv is faster with indirect conv. With DOT-CPUs, 32 deep conv is already faster