Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify activation and initializer alignment value #6109

Merged
merged 3 commits into from
Dec 14, 2020
Merged

Unify activation and initializer alignment value #6109

merged 3 commits into from
Dec 14, 2020

Conversation

SherlockNoMad
Copy link
Contributor

Description: Unify activation and initializer tensors to both align by 256 bytes

@SherlockNoMad SherlockNoMad added training issues related to ONNX Runtime training; typically submitted using template core runtime issues related to core runtime labels Dec 11, 2020
@SherlockNoMad SherlockNoMad requested a review from a team as a code owner December 11, 2020 07:11
ke1337
ke1337 approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@ke1337 ke1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

codemzs
codemzs reviewed Dec 14, 2020
View reviewed changes
Copy link
Member

@codemzs codemzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dismissing my hold.

@codemzs codemzs self-requested a review December 14, 2020 20:28
codemzs
codemzs reviewed Dec 14, 2020
View reviewed changes
Copy link
Member

@codemzs codemzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dismissing my hold.

@codemzs codemzs dismissed their stale review December 14, 2020 20:31

Seems like we can have a EP level alignment later.

@SherlockNoMad SherlockNoMad merged commit eb5c1f0 into master Dec 14, 2020
@SherlockNoMad SherlockNoMad deleted the bahuang/alignment branch December 14, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codemzs codemzs codemzs left review comments

@ke1337 ke1337 ke1337 approved these changes

@jessebenson jessebenson jessebenson approved these changes

@snnn snnn Awaiting requested review from snnn

@skottmckay skottmckay Awaiting requested review from skottmckay

@souptc souptc Awaiting requested review from souptc

@weixingzhang weixingzhang Awaiting requested review from weixingzhang

Assignees
No one assigned
Labels
core runtime issues related to core runtime training issues related to ONNX Runtime training; typically submitted using template
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SherlockNoMad @codemzs @jessebenson @ke1337