Introduce VariadicAlias, remove hardcoded alias limits #6106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SherlockNoMad
added
the
training
wschin
reviewed
Dec 11, 2020
| @@ -64,6 +65,10 @@ class KernelDef { | |||
| return alias_map_; | |||
| } | |||
|
|
|||
| const nonstd::optional<std::pair<int, int>>& VariadicAlias() const { | |||
| return variadic_alias_offsets_; | |||
There was a problem hiding this comment.
variadic_alias_offsets_ [](start = 11, length = 23)
How would it be used to represent Lamb's schema such as [eta, w0, g0, m0, v0, w1, g1, m1, v1] -> [w0, m0, v0, w1, g1, v1]? I think we need an initial bias and a vector to specify the input-to-output mapping in a peridic pattern. For my example here, the vector is [0, -1, 1, 2] where '-1' mean 'g0' is not mapped to output.
There was a problem hiding this comment.
lamb is too special a case, I will leave it out, to make the interface clean and simple.
There was a problem hiding this comment.
Many optimizers may fall into that category, not only Lamb.
wschin
reviewed
Dec 11, 2020
edgchen1
reviewed
Dec 11, 2020
wschin
previously approved these changes
Dec 11, 2020
wschin
approved these changes
Dec 11, 2020
pengwa
pushed a commit
that referenced
this pull request
Dec 28, 2020
* Introduce VariadicAlias, remove hardcoded alias limits * Include optional-lite in winml build Co-authored-by: Sherlock Huang <bahuang@OrtTrainingDev3.af05slrtruoetgaxwwjv5nsq5e.px.internal.cloudapp.net> (cherry picked from commit a53f4dd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Introduce VariadicAlias, remove hardcoded alias range limits