Support Fusion for 1 and 2 Inputs Bert Models Converted From tf #5993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangyems
reviewed
Dec 2, 2020
| @@ -142,12 +142,12 @@ def create_attention_node(self, mask_index, q_matmul, k_matmul, v_matmul, q_add, | |||
| raw=True) | |||
| self.model.add_initializer(bias) | |||
|
|
|||
| attnetion_inputs = [input, attention_node_name + '_qkv_weight', attention_node_name + '_qkv_bias'] | |||
| attention_inputs = [input, attention_node_name + '_qkv_weight', attention_node_name + '_qkv_bias'] | |||
wangyems
previously approved these changes
Dec 2, 2020
|
Could we add some test cases to test_optimizer? |
wangyems
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Describe your changes.
Update transformer model optimization tool to support 1 and 2 inputs models from Tensorflow. Note this fix is intended for fp32 models.
Motivation and Context