Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NNAPI] Support non-1d tensor for C of Gemm op #5982

Merged
merged 4 commits into from
Dec 2, 2020
Merged

[NNAPI] Support non-1d tensor for C of Gemm op #5982

merged 4 commits into from
Dec 2, 2020

Conversation

guoyu-wang
Copy link
Contributor

Description: [NNAPI] Support non-1d tensor for C of Gemm op

Motivation and Context

  • Onnx gemm can have multi-dimensional C for Gemm, but NNAPI only supports 1d tensor
  • Add support for multi-dimensional C for Gemm if it can be squeezed to a 1d tensor
  • Update add squeeze helper to check Android API level

@guoyu-wang guoyu-wang requested a review from skottmckay December 1, 2020 07:11
@guoyu-wang guoyu-wang requested a review from a team as a code owner December 1, 2020 07:11
skottmckay
skottmckay approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@skottmckay skottmckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@guoyu-wang guoyu-wang merged commit cdacee6 into master Dec 2, 2020
@guoyu-wang guoyu-wang deleted the gwang-msft/nnapi_gemm_c_squeeze branch December 2, 2020 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skottmckay skottmckay skottmckay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guoyu-wang @skottmckay