Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OpenVINO]Fix memory leak upon exception throwing #5954

Merged
merged 2 commits into from
Nov 27, 2020
Merged

[OpenVINO]Fix memory leak upon exception throwing #5954

merged 2 commits into from
Nov 27, 2020

Conversation

mosdav
Copy link
Contributor

@mosdav mosdav commented Nov 26, 2020

  • Make sure to free the output_shape vector even if Output names mismatch between OpenVINO and ONNX exception is thrown
  • Piggy back this PR to remove un-needed call to fstream close method

@mosdav mosdav requested a review from a team as a code owner November 26, 2020 15:38
snnn
snnn previously approved these changes Nov 26, 2020
View reviewed changes
snnn
snnn approved these changes Nov 27, 2020
View reviewed changes
Copy link
Member

@snnn snnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge it first and leave the remaining improvements as TODO.

@snnn snnn merged commit 5f5d4a1 into microsoft:master Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snnn snnn snnn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mosdav @snnn