Expose knobs to create and share (CPU) allocators across sessions in C# and Python #5634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hariharans29
commented
Oct 29, 2020
hariharans29
commented
Oct 29, 2020
yuslepukhin
reviewed
Nov 2, 2020
yuslepukhin
reviewed
Nov 2, 2020
yuslepukhin
reviewed
Nov 2, 2020
| @@ -479,6 +479,11 @@ struct IoBinding : public Base<OrtIoBinding> { | |||
| void ClearBoundOutputs(); | |||
| }; | |||
|
|
|||
| struct ArenaCfg : Base<OrtArenaCfg> { | |||
| explicit ArenaCfg(std::nullptr_t) {} | |||
| ArenaCfg(size_t max_mem, int arena_extend_strategy, int initial_chunk_size_bytes, int max_dead_bytes_per_chunk); | |||
There was a problem hiding this comment.
ArenaCfg [](start = 2, length = 8)
perhaps a factory method would be a good idea?
There was a problem hiding this comment.
But why though ? Why move from an established pattern ? Can you please elaborate on why it will be a good idea for this ?
hariharans29
changed the title
hariharans29
commented
Nov 19, 2020
yuslepukhin
reviewed
Nov 19, 2020
yuslepukhin
reviewed
Nov 19, 2020
yuslepukhin
reviewed
Nov 19, 2020
| ORT_API2_STATUS(CreateArenaCfg, _In_ size_t max_mem, int arena_extend_strategy, int initial_chunk_size_bytes, | ||
| int max_dead_bytes_per_chunk, _Outptr_ OrtArenaCfg** out); | ||
|
|
||
| ORT_CLASS_RELEASE(ArenaCfg); |
There was a problem hiding this comment.
ORT_CLASS_RELEASE(ArenaCfg); [](start = 2, length = 28)
Normally, this would be declared automatically
yuslepukhin
reviewed
Nov 19, 2020
yuslepukhin
reviewed
Nov 19, 2020
hariharans29
commented
Nov 21, 2020
hariharans29
commented
Nov 21, 2020
pranavsharma
approved these changes
Nov 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The C# and Python API follow-up for the feature added in #4813
The motivation is to allow C# and Python users to create multiple sessions that are backed by the same arena based allocator should they choose to
Motivation and Context
C# <-> C/C++ <-> Python API parity