Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MKLML build config #5559

Merged
merged 5 commits into from
Oct 21, 2020
Merged

Remove MKLML build config #5559

merged 5 commits into from
Oct 21, 2020

Conversation

snnn
Copy link
Member

@snnn snnn commented Oct 21, 2020

Description:

Remove MKLML build config

Motivation and Context

  • Why is this change required? What problem does it solve?

No one needs it anymore.

  • If it fixes an open issue, please link to the issue here.

@snnn snnn requested a review from a team as a code owner October 21, 2020 03:11
@pranavsharma
Copy link
Contributor

Should we still keep the build option and other infra around so that users can build from source if required? We just have to stop maintaining the packaging pipelines and pushing pkgs for this.

@snnn
Copy link
Member Author

snnn commented Oct 21, 2020

Should we still keep the build option and other infra around so that users can build from source if required? We just have to stop maintaining the packaging pipelines and pushing pkgs for this.

Yes, we can. But I worry it will be quickly out of maintain. For example, the #ifdefs for PrePack functions are subtle, they could be easily missed.

It's up to you. If you want to keep this change small, I can scope it down to just the yaml files.

@pranavsharma
Copy link
Contributor

Should we still keep the build option and other infra around so that users can build from source if required? We just have to stop maintaining the packaging pipelines and pushing pkgs for this.

Yes, we can. But I worry it will be quickly out of maintain. For example, the #ifdefs for PrePack functions are subtle, they could be easily missed.

It's up to you. If you want to keep this change small, I can scope it down to just the yaml files.

Ok, then let's remove it. Things going out-of-date and having to answer support questions is not good.

pranavsharma
pranavsharma previously approved these changes Oct 21, 2020
View reviewed changes
@snnn snnn merged commit 5802fe1 into master Oct 21, 2020
@snnn snnn deleted the snnn/mklml branch October 21, 2020 20:11
hariharans29 added a commit that referenced this pull request Nov 18, 2020
@hariharans29
Revert "Remove MKLML build config (#5559)"
8d718c1 
This reverts commit 5802fe1.
hariharans29 added a commit that referenced this pull request Nov 19, 2020
@hariharans29
Revert "Remove MKLML build config (#5559)" (#5855)
62508ef
snnn added a commit that referenced this pull request Dec 25, 2020
@snnn
Remove MKLML build config (#5559)
f1ef685 
Remove MKLML build config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavsharma pranavsharma pranavsharma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snnn @pranavsharma