Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace change on ort flatbuffers schema #4886

Merged
merged 3 commits into from
Aug 22, 2020
Merged

Namespace change on ort flatbuffers schema #4886

merged 3 commits into from
Aug 22, 2020

Conversation

guoyu-wang
Copy link
Contributor

Description: Namespace change on ort flatbuffers schema

Motivation and Context

  • Previously we use the same name for class and namespace, which caused error while using the generated code, add "_" to the name space
  • Previously I accidentally add the flatbuffers submodule under root folder, move it under cmake/external

@guoyu-wang guoyu-wang requested a review from skottmckay August 21, 2020 21:38
@guoyu-wang guoyu-wang requested a review from a team as a code owner August 21, 2020 21:38
skottmckay
skottmckay approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@skottmckay skottmckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@guoyu-wang guoyu-wang merged commit 82bc21e into master Aug 22, 2020
@guoyu-wang guoyu-wang deleted the ort_mobile_serialize branch August 22, 2020 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skottmckay skottmckay skottmckay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guoyu-wang @skottmckay