Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Port image tests from WAI #3365

Merged
merged 9 commits into from
Apr 1, 2020
Merged

Conversation

tiagoshibata
Copy link
Contributor

Description: Port tests and convert data driven tests to googletest

@tiagoshibata tiagoshibata requested a review from a team as a code owner March 30, 2020 15:40
@tiagoshibata tiagoshibata changed the title Port image tests from WAI [WIP] Port image tests from WAI Mar 30, 2020
@tiagoshibata
Copy link
Contributor Author

tiagoshibata commented Mar 30, 2020

I'll see if it's fine to keep the tests using brand images

Edit: fixed

@tiagoshibata tiagoshibata force-pushed the user/ticastro/image-tests branch from b29d1b5 to 4e789dd Compare March 30, 2020 22:29
martinb35
martinb35 previously approved these changes Apr 1, 2020
ryanlai2
ryanlai2 previously approved these changes Apr 1, 2020
@tiagoshibata tiagoshibata dismissed stale reviews from ryanlai2 and martinb35 via 04f3a26 April 1, 2020 20:55
@tiagoshibata tiagoshibata merged commit 1671072 into master Apr 1, 2020
@tiagoshibata tiagoshibata deleted the user/ticastro/image-tests branch April 1, 2020 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants