Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin transformer and optimum version #21650

Merged
merged 5 commits into from
Aug 7, 2024
Merged

Pin transformer and optimum version #21650

merged 5 commits into from
Aug 7, 2024

Conversation

mszhanyi
Copy link
Contributor

@mszhanyi mszhanyi commented Aug 7, 2024 •
edited
Loading

Description

Motivation and Context

To fix whisper test failure

skottmckay
skottmckay previously approved these changes Aug 7, 2024
View reviewed changes
@kunal-vaishnavi
Copy link
Contributor

Can we keep the transformers and optimum versions within a range to allow users with older package versions to still use the existing files? We did something similar with the transformers version for LLaMA.

onnxruntime/onnxruntime/python/tools/transformers/models/llama/requirements.txt

Line 2 in b95aa05

transformers>=4.33.2,<= 4.37.2

@mszhanyi @kunal-vaishnavi
Update onnxruntime/python/tools/transformers/models/whisper/requireme…
18b95aa 
…nts.txt

Co-authored-by: kunal-vaishnavi <115581922+kunal-vaishnavi@users.noreply.github.com>
@mszhanyi @kunal-vaishnavi
Update onnxruntime/python/tools/transformers/models/whisper/requireme…
dda4d06 
…nts.txt

Co-authored-by: kunal-vaishnavi <115581922+kunal-vaishnavi@users.noreply.github.com>
@mszhanyi
Copy link
Contributor Author

mszhanyi commented Aug 7, 2024 •
edited
Loading

Can we keep the transformers and optimum versions within a range to allow users with older package versions to still use the existing files? We did something similar with the transformers version for LLaMA.

onnxruntime/onnxruntime/python/tools/transformers/models/llama/requirements.txt

Line 2 in b95aa05

transformers>=4.33.2,<= 4.37.2

Let's try it in next PRs. we need to unblock other's PR requests first

@mszhanyi mszhanyi merged commit 621b16f into main Aug 7, 2024
92 of 97 checks passed
@mszhanyi mszhanyi deleted the zhanyi/locktransformer branch August 7, 2024 09:47
@mszhanyi mszhanyi added the release:1.19.0 Cherry pick to ORT 1.19 label Aug 9, 2024
prathikr pushed a commit that referenced this pull request Aug 9, 2024
@mszhanyi @prathikr
Pin transformer and optimum version (#21650)
cda7737 
### Description
<!-- Describe your changes. -->



### Motivation and Context
To fix whisper test failure
prathikr pushed a commit that referenced this pull request Aug 12, 2024
@mszhanyi @prathikr
Pin transformer and optimum version (#21650)
b67af53 
### Description
<!-- Describe your changes. -->



### Motivation and Context
To fix whisper test failure
@prathikr prathikr added the cherry-picked Cherry-picked for a cherrypicks branch label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunal-vaishnavi kunal-vaishnavi kunal-vaishnavi approved these changes

@tianleiwu tianleiwu tianleiwu approved these changes

@skottmckay skottmckay skottmckay left review comments

Assignees
No one assigned
Labels
cherry-picked Cherry-picked for a cherrypicks branch release:1.19.0 Cherry pick to ORT 1.19
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mszhanyi @kunal-vaishnavi @skottmckay @tianleiwu @prathikr