Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruff and clang-format versions #21479

Merged
merged 9 commits into from
Jul 24, 2024
Merged

Conversation

justinchuby
Copy link
Contributor

@justinchuby justinchuby commented Jul 24, 2024

ruff -> 0.5.4
clang-format -> 18

@justinchuby justinchuby merged commit c203d89 into main Jul 24, 2024
95 of 98 checks passed
@justinchuby justinchuby deleted the justinchu/ruff-clangformat-2 branch July 24, 2024 18:50
@@ -73,7 +73,7 @@ def add_github_dep(name, parsed_url):
return
# Make a REST call to convert to tag to a git commit
url = f"https://api.github.com/repos/{org_name}/{repo_name}/git/refs/tags/{tag}"
print("requesting %s ..." % url)
print("requesting {url} ...")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not right. Now it prints the string as it is.

requesting {url} ...

@justinchuby

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot an f""

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix forward

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants