Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UseDotNet5 task #15372

Merged
merged 7 commits into from
Apr 5, 2023
Merged

Add UseDotNet5 task #15372

merged 7 commits into from
Apr 5, 2023

Conversation

smk2007
Copy link
Member

@smk2007 smk2007 commented Apr 5, 2023

.NET5 is not installed by default on build machines.

Add the UseDotNet@2 task to install .NET5.

@smk2007 smk2007 requested a review from a team as a code owner April 5, 2023 01:04
@smk2007 smk2007 changed the title User/sheilk/usedotnet Add UseDotNet5 task Apr 5, 2023
@skottmckay
Copy link
Contributor

.net 5.0 is end of life and out of support. Is there a requirement to still target that? Curious as I was going to remove support for it from the ORT C# csproj.

@smk2007 smk2007 merged commit 1cd687e into rel-1.14.1-stft Apr 5, 2023
@smk2007 smk2007 deleted the user/sheilk/usedotnet branch April 5, 2023 11:19
@smk2007
Copy link
Member Author

smk2007 commented Apr 5, 2023

.net 5.0 is end of life and out of support. Is there a requirement to still target that? Curious as I was going to remove support for it from the ORT C# csproj.

We needed to fix the build and this was blocking a patch release.
In main as we go forward we will deprecate in favor of .NET7.

smk2007 added a commit that referenced this pull request Apr 5, 2023
.NET5 is not installed by default on build machines.

Add the UseDotNet@2 task to install .NET5.
preetha-intel pushed a commit to intel/onnxruntime that referenced this pull request Jun 6, 2023
.NET5 is not installed by default on build machines.

Add the UseDotNet@2 task to install .NET5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants