-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement contrib op CropAndResize #1277
Conversation
Did you copied the code or you implemented the code? |
Will add copyright. |
synced offline, |
The code looks a lot similar to roialign. Can we reuse that instead of duplicating? |
The algorithm is totally different. The similar code happened in input validation, so I change this part accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except the one comment.
Since you are adding a new contrib op you should also update this file: https://github.com/microsoft/onnxruntime/blob/master/docs/ContribOperators.md (Please note: this file is auto-generated so use this script (https://github.com/microsoft/onnxruntime/blob/master/tools/python/gen_doc.py) to generate it) |
Generated, thanks |
Description: Implement contrib op CropAndResize.
Motivation and Context
CropAndResize is from tensorflow. This is an important op which is used widely in object detection models.