Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement contrib op CropAndResize #1277

Merged
merged 11 commits into from
Jun 25, 2019
Merged

Implement contrib op CropAndResize #1277

merged 11 commits into from
Jun 25, 2019

Conversation

jiafatom
Copy link
Contributor

Description: Implement contrib op CropAndResize.

Motivation and Context
CropAndResize is from tensorflow. This is an important op which is used widely in object detection models.

@jiafatom jiafatom requested a review from a team as a code owner June 21, 2019 21:47
@snnn
Copy link
Member

snnn commented Jun 21, 2019

Did you copied the code or you implemented the code?

@jiafatom
Copy link
Contributor Author

Did you copied the code or you implemented the code?

Will add copyright.

@jiafatom
Copy link
Contributor Author

Please note , this op doesn't support mini-batch, so it will cause a lot of problems. I'd prefer to avoid using it.

synced offline, h and w are fixed across all images after preprocessing step, so it can do mini-batch.

@pranavsharma
Copy link
Contributor

The code looks a lot similar to roialign. Can we reuse that instead of duplicating?

@jiafatom
Copy link
Contributor Author

The code looks a lot similar to roialign. Can we reuse that instead of duplicating?

The algorithm is totally different. The similar code happened in input validation, so I change this part accordingly.

Copy link
Contributor

@pranavsharma pranavsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the one comment.

@askhade
Copy link
Contributor

askhade commented Jun 24, 2019

Since you are adding a new contrib op you should also update this file: https://github.com/microsoft/onnxruntime/blob/master/docs/ContribOperators.md

(Please note: this file is auto-generated so use this script (https://github.com/microsoft/onnxruntime/blob/master/tools/python/gen_doc.py) to generate it)

@jiafatom
Copy link
Contributor Author

Since you are adding a new contrib op you should also update this file: https://github.com/microsoft/onnxruntime/blob/master/docs/ContribOperators.md
(Please note: this file is auto-generated so use this script (https://github.com/microsoft/onnxruntime/blob/master/tools/python/gen_doc.py) to generate it)

Generated, thanks

@jiafatom jiafatom merged commit c9d83a5 into master Jun 25, 2019
@jiafatom jiafatom deleted the crop_and_resize branch June 25, 2019 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants