Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat attribute warning as non-error on cross compiling ARM #1261

Merged
merged 2 commits into from
Jun 24, 2019
Merged

Treat attribute warning as non-error on cross compiling ARM #1261

merged 2 commits into from
Jun 24, 2019

Conversation

RandySheriffH
Copy link
Contributor

@RandySheriffH RandySheriffH commented Jun 19, 2019 •
edited
Loading

Address issue:
#1232
When building ARM by cross-compiling, compiler treat eigen attributes warning as error.

@RandySheriffH RandySheriffH requested a review from a team as a code owner June 19, 2019 23:11
@RandySheriffH RandySheriffH changed the title abandon attribute error on cross compiling Treate attribute warning as non-error on cross compiling ARM Jun 19, 2019
@RandySheriffH RandySheriffH changed the title Treate attribute warning as non-error on cross compiling ARM Treat attribute warning as non-error on cross compiling ARM Jun 19, 2019
@RandySheriffH RandySheriffH mentioned this pull request Jun 19, 2019
Closed
snnn
snnn reviewed Jun 19, 2019
View reviewed changes
Copy link
Member

@snnn snnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't change here. There is a special cmake options for disabling that. ONNXRUNTIME_DEV_MODE. Please use that var to control it. You may adjust such things in build.py or ci build scripts.

@snnn
Copy link
Member

snnn commented Jun 19, 2019

This is a more general issue, not specific to cross compiling.

@RandySheriffH
Copy link
Contributor Author

RandySheriffH commented Jun 19, 2019 •
edited
Loading

onnxruntime_DEV_MODE is for escalating warnings, not for suppressing them.

@RandySheriffH
Copy link
Contributor Author

RandySheriffH commented Jun 19, 2019 •
edited
Loading

What do u mean it is generic - the issue is prevalent in many other build settings?

@RandySheriffH RandySheriffH merged commit 671c15a into master Jun 24, 2019
@snnn snnn deleted the rashuai/BuildArm branch June 24, 2019 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snnn snnn snnn approved these changes

@pranavsharma pranavsharma Awaiting requested review from pranavsharma

@hariharans29 hariharans29 Awaiting requested review from hariharans29

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RandySheriffH @snnn @RandyShuai