Fix install_onnx.sh issue #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yuslepukhin Any comment? #Resolved |
skottmckay
reviewed
Jun 12, 2019
RandySheriffH
changed the title
|
Randy, you need to follow the PR guidelines that just have been published. It is good that you quote me, however, it does not describe the overall motivation for the PR and the reason for this change. In reply to: 501001784 [](ancestors = 501001784) |
yuslepukhin
reviewed
Jun 12, 2019
Catch with latest mater
snnn
previously approved these changes
Jun 13, 2019
yuslepukhin
approved these changes
Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue in install_onnx.sh. The installation sequence of onnx versions should be kept strictly following onnx123, onnx130, onnx141, onnx150 and onnxtip. Further, we want to keep onnxtip after script finish running.
Quoting Dmitri's comment from another PR:
/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
"
Now you have to update strings in 3 places. Can we make it only one place for each commit?
For example the first occurence of commit is purely a comment. We could add a trailing comment for each entry in the map.
In fact, the map entries are self-documenting, no need for separate comments.
Or you simply describe in one line that Install ONNX for each release with specific commits.
Also, could we, instead of map declare a sequence of strings and each string is a composite of "committag".
We could iterate through it in order, split it obtaining commit and tag and then use it as before.
"