feat(react-file-type-icons): Changing FileIconType-based icon searching to use the same scalable method used for file extensions #32947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ileextension based filetype icons.
…/bigbadcapers/fluentui into caperez/sep-filetype-icon-update
…ethod used for file extensions
# Conflicts (merged and resolved): # packages/react-file-type-icons/src/FileIconType.ts # packages/react-file-type-icons/src/FileTypeIconMap.ts # packages/react-file-type-icons/src/getFileTypeIconProps.ts
📊 Bundle size report✅ No changes found |
… wrapped in an if statement to filter unwanted properties from the prototype guard-for-in
|
Hey @ThomasMichon / @soettl I put this together a few weeks ago, aiming to make future addons more scalable. Would appreciate your take on the change. |
# Conflicts: # packages/react-file-type-icons/src/FileIconType.ts # packages/react-file-type-icons/src/getFileTypeIconProps.ts
|
hi @dzearing @ecraig12345 @KatherineThayerMicrosoft would appreciate your take on this PR and if you see any issues with this change of method |
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
|
I don't work on Fluent any more. I think @tomi-msft owns icons now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
masterbranchreact-experimentsunder the FileTypeIcon storybook.yarn changelocallyChange in Behavior
Adding a new non-file-extension-based filetype icon required code change in multiple places. We've changed it so you only need to register the new type in FileIconType.ts and map it to an existing icon image in FileTypeIconMap.ts.
The API and calling pattern has not changed. Overall line code count and complexity have been reduced.