Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Linux/OS X symbol server requests #995

Merged
merged 12 commits into from
May 12, 2022
Merged

Implement Linux/OS X symbol server requests #995

merged 12 commits into from
May 12, 2022

Conversation

leculver
Copy link
Contributor

@leculver leculver commented May 11, 2022

  • Properly implement the symbol server protocol for requesting ELF and Mach-O files.
  • Unfortunately this requires version bumping ClrMD to 2.1 because this is a breaking change.
  • This means we now support cross-OS debugging for the scenarios that CLR Diagnostics supports. E.G. it's possible to debug Linux coredumps on a Windows machine for recent builds of .Net Core which support it.
  • Theoretical support for OS X -> Windows debugging exists since we plan to build that eventually, but currently the CLR Diagnostics team has not built the dac PE image that can debug OS X dumps.
  • Fixed some Linux and OS X build issues.
  • Do a better job parsing symbol server paths.
  • Better understand the kinds of symbol servers out there and make less requests that will never be filled.

Fixes #977.
Fixes #927.
Closes #771.

@leculver leculver requested a review from mikem8361 May 11, 2022 20:23
@leculver leculver merged commit ec4164a into microsoft:master May 12, 2022
@leculver leculver deleted the symbolServer branch May 12, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants