Keybinding for Show SQL Pane #9750
Conversation
…into alex/keybinding-showsqlpane
…into alex/keybinding-showsqlpane
…into alex/keybinding-showsqlpane
…into alex/keybinding-showsqlpane
…into alex/keybinding-showsqlpane
…into alex/keybinding-showsqlpane
…into alex/keybinding-showsqlpane
…into alex/keybinding-showsqlpane
…into alex/keybinding-showsqlpane
…into alex/keybinding-showsqlpane
…into alex/keybinding-showsqlpane
…into alex/keybinding-showsqlpane
|
Option to always show SQL Pane added as requested by gregveres in #3763 |
There was a problem hiding this comment.
I'm not sure where the requirement for the user setting originated from, though I'm not necessarily opposed to it, I just don't see it discussed in the bug or recall discussing it elsewhere? Though the default should be false. Also, I think the keyboarding you choose conflicts with existing keyboard shortcut for a common action.
| @@ -18,6 +24,20 @@ const editDataEditorDescriptor = new EditorDescriptor( | |||
| 'EditData' | |||
| ); | |||
|
|
|||
| const configurationRegistry = <IConfigurationRegistry>Registry.as(ConfigExtensions.Configuration); | |||
There was a problem hiding this comment.
why are we adding this setting? i.e. has this been requested by a customer?
There was a problem hiding this comment.
Yes, a customer requested this feature should be added
#3763 (comment)
| 'properties': { | ||
| 'editor.showEditDataSqlPaneOnStartup': { | ||
| 'type': 'boolean', | ||
| 'default': true, |
There was a problem hiding this comment.
should the default be false to main compatibility with current behavior?
| id: editDataActions.ShowQueryPaneAction.ID, | ||
| weight: KeybindingWeight.EditorContrib, | ||
| when: undefined, | ||
| primary: KeyMod.CtrlCmd | KeyCode.US_QUOTE, |
There was a problem hiding this comment.
is this the keybinding currently used to show the terminal? I suggest we leave the keybinding unassigned by default and let user configure it themselves since we are running out of available keyboard shortcuts.
…into alex/keybinding-showsqlpane
Added a keybinding in the edit data contribution file that toggles show SQL pane.
This PR fixes #3763