Removing some unnecessary differences #9495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonydresser
commented
Mar 7, 2020
| @@ -1,39 +0,0 @@ | |||
| trigger: | |||
There was a problem hiding this comment.
This file is no longer relavent
anthonydresser
commented
Mar 7, 2020
| // await config.update('ignoreMissingGitWarning', true, true); | ||
| // } | ||
| // } | ||
| /* {{SQL CARBON EDIT}} - Comment out function that is unused due to our edit below |
There was a problem hiding this comment.
Changing the comment style to reduce the change of conflicts.
anthonydresser
commented
Mar 7, 2020
| @@ -29,31 +29,6 @@ import { Disposable } from 'vs/base/common/lifecycle'; | |||
| import { IWorkbenchContribution, Extensions as WorkbenchContributionsExtensions, IWorkbenchContributionsRegistry } from 'vs/workbench/common/contributions'; | |||
| import { Registry } from 'vs/platform/registry/common/platform'; | |||
| import { LifecyclePhase } from 'vs/platform/lifecycle/common/lifecycle'; | |||
| import { INotebookService } from 'sql/workbench/services/notebook/browser/notebookService'; | |||
There was a problem hiding this comment.
Unsure how this got back in, but this was removed in https://github.com/microsoft/azuredatastudio/pull/8995/files
aaomidi
approved these changes
Mar 8, 2020
Charles-Gagnon
approved these changes
Mar 8, 2020
# Conflicts: # src/vs/workbench/contrib/codeEditor/browser/saveParticipants.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some differences and fix some of the differences to reduce merge conflicts.