-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove insider build check #7926
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charles-Gagnon
approved these changes
Oct 23, 2019
MaddyDev
approved these changes
Oct 23, 2019
chlafreniere
approved these changes
Oct 24, 2019
finally, the last commit fixed the issue. merging now. |
kburtram
pushed a commit
that referenced
this pull request
Oct 24, 2019
* remove insider build check * fix welcome page not load issue
aaomidi
pushed a commit
that referenced
this pull request
Oct 25, 2019
* Fix for relative links not being resolved in notebook outputs (#7966) * Fix for relative links not being resolved * Add comment * check for ownerDocument focus for focus (#7964) * Update recommended package versions for ps (#7972) * Notebooks: ensure python path dirs added to path on session start (#7968) * ensure python path dirs add to path session start * Change logic slightly * PR feedback from Charles * Fix node infinitely loading when a firewall dialog is cancelled (#7970) * add back icons for azure actions * fix firewall infinite loop * formatting * change message to firewall canceled * fix tests * remove insider build check (#7926) * remove insider build check * fix welcome page not load issue * Fix troubleshoot URL lookup (#7978) * Change BDC view errors to use modal dialog instead of error toast (#7985) * Change BDC view errors to use modal dialog instead of error toast * Move to common control * revert the notebook background execution (#7984) * hide save book action from command pallet (#7981) * make the azdata install url configurable (#7989) * make the azdata install url configurable * use settings without reloading * comments * Use selected DB for import wizard schema list (#7878) * Update fileConfigPage.ts * Update fileConfigPage.ts * Update fileConfigPage.ts * Update fileConfigPage.ts * Update fileConfigPage.ts * Update fileConfigPage.ts * Update fileConfigPage.ts * Update fileConfigPage.ts * Update fileConfigPage.ts * Add SQL Managed Instance support and sorting (#7996) - Add SQL Instances folder and support using existing SQLClient API - Sort subscriptions in tree and quickpick for easier search - Sort all resources (Databases, Servers, Instances) alphabetically too Not in this PR: - Will experiment with Graph API for faster perf & easier addition of other Azure resources such as PostgreSQL * Fix starting and separators in a row (#7861) * Fixes some code coverage issues (#7994) * Fix code coverage issues * Fix some code coverage stuff * builtinExtension-insiders to builtinExtension (#7973) * builtinExtension-insiders to builtinExtension * maintain both insiders and stable. * builtinExtension.js is for build time and skipping the check for dev. * check quality and pick insider vs stable json * Remove RC from strings (#8001) * delete workflow (#8000) * Always send \n instead of \r\n to Jupyter kernel (#7995) * Always send \n instead of \r\n to kernel * Use replace instead of split/join * reclassified autoinstallrequired message to error (#7986) * reclassified autoinstallrequired message to error * Changed level to warning * search book gone from command palette (#8002) * Work with single ext loc file (#7894) * try loc with single file model * adding filter and languages * add links in langpack json * changing variable name and limiting the list to only tested extensions * Fix column text overflow on BDC status pages (#7928) * Fix column text overflow on status page * Fix typo * Fix another typo * suppress the alert (#8007) * Fix Issue when Saving Wrong Kernel (#7974) * Only fire kernelChangeEmitter after lang set * Fix unused import found by lgtm * Fix comment * Fix for Markdown File in Jupyter Books Viewlet not Opening After 2x (#8009) * fix for markdown not opening after opened twice * PR comment to add return type * Adjusting context menu for SqlOnDemand (#8018) * Testing out ci with workflows (#8005) * add workflow for ci * add another step * remove more steps * fix stdin cancel breaks notebook (#8012) * serverManager to decide if server start needed (#8017) * pass install paths to notebooks (#8008) * pass install paths to notebooks * onComplete * discover and publish actual installation Path * pass the path to notebook * minor fixes needed post merge of code from remote * fix some errors * remove unused variable * Don't pack the hgh level node_modules directory (#7998)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #7904 and #5987