Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update timeout #7446

Merged
merged 1 commit into from
Oct 1, 2019
Merged

update timeout #7446

merged 1 commit into from
Oct 1, 2019

Conversation

alanrenmsft
Copy link
Contributor

not sure whether I am the only one, 20 seconds timeout is never enough for my dev environments to launch ADS after git clean. and I noticed we have 45 seconds timeout elsewhere in the launch.json file which seems to be good enough for my MacBook.

Copy link
Contributor

@Charles-Gagnon Charles-Gagnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is one of those things that I often had changed locally but never bothered to send out a review for - thanks!

@aaomidi
Copy link
Contributor

aaomidi commented Oct 1, 2019

This is only an issue on the first run from my understanding, but good to have.

@alanrenmsft alanrenmsft merged commit 7162272 into master Oct 1, 2019
@alanrenmsft alanrenmsft deleted the alanren/launchTime branch October 1, 2019 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants