Bug/Accessibility fix for 6796 (partial), 6800 and 6745 #6882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udeeshagautam
requested review from
anthonydresser,
Benjin,
kisantia and
alanrenmsft
udeeshagautam
changed the title
udeeshagautam
commented
Aug 22, 2019
| for (const col of this._checkboxColumns) { | ||
| this.registerCheckboxPlugin(col); | ||
| } | ||
| Object.keys(this._checkboxColumns).forEach(col => this.registerCheckboxPlugin(this._checkboxColumns[col])); |
There was a problem hiding this comment.
@anthonydresser the old code here seems to have stopped working after some lint related cleanup. Please let me know if the new change causes any lint related warning or errors?
Benjin
approved these changes
Aug 22, 2019
alanrenmsft
approved these changes
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for
#6796 (partial)
Checkbox cells in table don't have name - fixed
Empty cells in table don't have name - not fixed needs followup
#6800
After space/enter on checkbox cell - focus doesn't stay correctly on the cell
#6745
After DacFx wizard opens the focus should shift to the wizard
Regression
After Lint update checkbox columns were not getting rendered. For --> Foreach change fixes this