Bug/accessibility - Focus related issues #6859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udeeshagautam
requested review from
Benjin,
alanrenmsft,
kisantia and
anthonydresser
anthonydresser
approved these changes
Aug 21, 2019
kisantia
approved these changes
Aug 21, 2019
alanrenmsft
approved these changes
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains fix for fix for
#6798
DacFx Wizard focus should be on the new wizard page content after pressing next button (currently it keeps on footer buttons). The Fix for this is in show() function in Wizard model
#6851
When Schema compare source/target dialog is opened - the focus remains on the uber ADS document. The simple fix here is to explicitly calling the focus on default radio button once dialog is opened.
Note that the core component used here is modal.ts which does try to handle focus but doesn't work in our case because it tries to find the first focusable element of document which ends up being the overall ADS rather than the newly opened dialog. Changing this might lead to cascading effect hence handling this locally.